[vite-plugin] use the new resolve.builtins vite config to specify the cloudflare builtins#8104
Conversation
|
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-wrangler-8104You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8104/npm-package-wrangler-8104Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-wrangler-8104 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-workers-bindings-extension-8104 -O ./cloudflare-workers-bindings-extension.0.0.0-vf8981785a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf8981785a.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-create-cloudflare-8104 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-kv-asset-handler-8104miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-miniflare-8104@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-pages-shared-8104@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-unenv-preset-8104@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-vite-plugin-8104@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-vitest-pool-workers-8104@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-workers-editor-shared-8104@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-workers-shared-8104@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-workflows-shared-8104Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
6b2b51d to
7cab026
Compare
|
Rebased to see if this still works with the changes I made to nodejs compat |
| // Worker modules (CompiledWasm, Text, Data) | ||
| moduleRE.test(moduleId) || | ||
| // Node.js builtin node modules (they will be resolved to unenv aliases) | ||
| nodeBuiltInModules.has(moduleId); |
There was a problem hiding this comment.
Know we've discussed it before but it still doesn't really make sense to me that we have to externalize things again here. Agree this is correct for now though.
There was a problem hiding this comment.
I 100% totally agree 👍
I'll go and investigate this 👍 (but yeah for this PR I would keep it as is since this is also effects the other modules)
…he cloudflare builtins
8baebf4 to
8affca1
Compare
Closes flarelabs-net/vite-plugin-cloudflare#52
Note: in flarelabs-net/vite-plugin-cloudflare#52 I've done some extra work to also conditionally include/exclude the nodejs externals based on the nodejs_compat flag, I am happy to do that here as well but I figured that maybe it'd be cleaner to do one thing at a time, and first simply use the new
resolve.builtinsoption before optimizing further