fix(vitest-pool-workers) Fix support for query params with repeated keys#7668
fix(vitest-pool-workers) Fix support for query params with repeated keys#7668edmundhung merged 1 commit intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 260270b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9382161 to
260270b
Compare
|
The change is inspired by |
edmundhung
left a comment
There was a problem hiding this comment.
Thanks for the PR! This looks great to me. I will run the e2e tests for a sanity check and merge it once everything passes. 👍🏼
|
Congratulations @romeupalos, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm5l7w3j406680cl5g9otx1zn This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
|
I think this breaks anyone who's currently doing matching against single query params |
|
Makes sense 👍🏼 Added tests on #7682 |
Fixes #7667
Support interception of URLs with repeated key/name in its query params. e.g.,
/index.html?a=1&a=2.