Add warning for smart placement w/assets#7568
Merged
CarmenPopoviciu merged 2 commits intomainfrom Dec 19, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 3c6ad5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9 tasks
8312438 to
529b021
Compare
Contributor
Author
|
Smart placement docs here: |
WillTaylorDev
commented
Dec 16, 2024
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-wrangler-7568You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7568/npm-package-wrangler-7568Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-wrangler-7568 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-workers-bindings-extension-7568 -O ./cloudflare-workers-bindings-extension.0.0.0-v5b7349de4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v5b7349de4.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-create-cloudflare-7568 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-kv-asset-handler-7568npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-miniflare-7568npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-pages-shared-7568npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-unenv-preset-7568npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-vitest-pool-workers-7568npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-workers-editor-shared-7568npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-workers-shared-7568npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-workflows-shared-7568Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
21f93eb to
c826454
Compare
b4df55e to
abb9de8
Compare
Contributor
Author
|
c826454 to
ab124d9
Compare
bd1116d to
95e00b2
Compare
ee587cf to
3ce560e
Compare
rozenmd
reviewed
Dec 19, 2024
Base automatically changed from
willtaylor/experimental_serve_directly-validation
to
main
December 19, 2024 10:09
469ece6 to
f5c081f
Compare
469ece6 to
79c1528
Compare
79c1528 to
7a6a79d
Compare
CarmenPopoviciu
approved these changes
Dec 19, 2024
7a6a79d to
3c6ad5e
Compare
penalosa
approved these changes
Dec 19, 2024
Merged
penalosa
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Provide validation around experimental_serve_directly usage in dev and deploy * Update based on PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Provides a warning if using smart placement. Internal discussions still ongoing on whether to hard block on this instead of warn.