Add Warning about browser rendering when running locally#7533
Add Warning about browser rendering when running locally#7533emily-shen merged 4 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 90d78a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9f810da to
c09902c
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-wrangler-7533You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7533/npm-package-wrangler-7533Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-wrangler-7533 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-cloudflare-workers-bindings-extension-7533 -O ./cloudflare-workers-bindings-extension.0.0.0-v4cad5d8ac.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v4cad5d8ac.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-create-cloudflare-7533 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-cloudflare-kv-asset-handler-7533npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-miniflare-7533npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-cloudflare-pages-shared-7533npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-cloudflare-unenv-preset-7533npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-cloudflare-vitest-pool-workers-7533npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-cloudflare-workers-editor-shared-7533npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-cloudflare-workers-shared-7533npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12601808065/npm-package-cloudflare-workflows-shared-7533Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
c09902c to
257a2b3
Compare
We usually test for this kind of stdout. See here for example. So we would def like to cover this warning as well by a unit test 🙏 |
0225a40 to
ed5e621
Compare
ed5e621 to
147d855
Compare
|
Agh so I had a look at why tests were failing. Turns out |
Nice, also i left some suggestions on working, would be nice if they can go in as well And Thanks for all the help! |
* Warn about browser rendering when running locally * fix warning check * update snapshot --------- Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
Fixes #BRAPI-120.
Add warning when running browser rendering locally