feat(wrangler): DX optimisations in wrangler dev --remote#7425
Merged
CarmenPopoviciu merged 1 commit intomainfrom Dec 19, 2024
Merged
feat(wrangler): DX optimisations in wrangler dev --remote#7425CarmenPopoviciu merged 1 commit intomainfrom
wrangler dev --remote#7425CarmenPopoviciu merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: e849ab5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/wrangler/src/api/startDevWorker/RemoteRuntimeController.ts
Outdated
Show resolved
Hide resolved
34022c7 to
e1c8f30
Compare
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-wrangler-7425You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7425/npm-package-wrangler-7425Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-wrangler-7425 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-workers-bindings-extension-7425 -O ./cloudflare-workers-bindings-extension.0.0.0-vab01249e3.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vab01249e3.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-create-cloudflare-7425 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-kv-asset-handler-7425npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-miniflare-7425npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-pages-shared-7425npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-unenv-preset-7425npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-vitest-pool-workers-7425npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-workers-editor-shared-7425npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-workers-shared-7425npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-workflows-shared-7425Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
14b81d2 to
a1cd8fc
Compare
penalosa
approved these changes
Dec 16, 2024
d98bc63 to
4fe76bb
Compare
andyjessop
approved these changes
Dec 19, 2024
Workers + Assets projects have, in certain situations, a relatively degraded `wrangler dev --remote` developer experience, as opposed to Workers proper projects. This is due to the fact that, for Workers + Assets, we need to make extra API calls to: 1. check for asset files changes 2. upload the changed assets, if any This commit improves the `wrangler dev --remote` DX for Workers + Assets, for use cases when the User Worker/assets change while the API calls for previous changes are still in flight. For such use cases, we have put an exit early strategy in place, that drops the event handler execution of the previous changes, in favour of the handler triggered by the new changes.
4fe76bb to
e849ab5
Compare
Merged
penalosa
pushed a commit
that referenced
this pull request
Jan 10, 2025
Workers + Assets projects have, in certain situations, a relatively degraded `wrangler dev --remote` developer experience, as opposed to Workers proper projects. This is due to the fact that, for Workers + Assets, we need to make extra API calls to: 1. check for asset files changes 2. upload the changed assets, if any This commit improves the `wrangler dev --remote` DX for Workers + Assets, for use cases when the User Worker/assets change while the API calls for previous changes are still in flight. For such use cases, we have put an exit early strategy in place, that drops the event handler execution of the previous changes, in favour of the handler triggered by the new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DEVX-1523
Workers + Assets projects have, in certain situations, a relatively degraded
wrangler dev --remotedeveloper experience, as opposed to Workers proper projects. This is due to the fact that, for Workers + Assets, we need to makeextra API calls to:
This commit improves the
wrangler dev --remoteDX for Workers + Assets, for use cases when the User Worker/assets change while the API calls for previous changes are still in flight. For such use cases, we have put an exit early strategy in place, that drops the event handler execution of the previous changes, in favour of the handler triggered by thenew changes.
For
before/afterscreenshots pls see DEVX-1523How these changes were tested
NOTE
Before

After

After

After
