Skip to content

workers-sdk causing PRs to workerd main to fail#13629

Merged
tewaro merged 1 commit into
mainfrom
tewaro/lockfile-stream-binding-workers-types
Apr 21, 2026
Merged

workers-sdk causing PRs to workerd main to fail#13629
tewaro merged 1 commit into
mainfrom
tewaro/lockfile-stream-binding-workers-types

Conversation

@tewaro

@tewaro tewaro commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

This was due to a version mismatch by PR #13615 being merged and later. PR #13234 had the earlier version of 4.20260420.1 but the version needed was 4.20260421.1. No tests because the only way to test is to run workerd cli.


Open in Devin Review

@tewaro tewaro requested a review from workers-devprod as a code owner April 21, 2026 21:45
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 21, 2026
@workers-devprod workers-devprod requested review from a team and emily-shen and removed request for a team April 21, 2026 21:46
@workers-devprod

workers-devprod commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@pkg-pr-new

pkg-pr-new Bot commented Apr 21, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13629

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13629

miniflare

npm i https://pkg.pr.new/miniflare@13629

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13629

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13629

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13629

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13629

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13629

wrangler

npm i https://pkg.pr.new/wrangler@13629

commit: c7ffcaf

@tewaro tewaro force-pushed the tewaro/lockfile-stream-binding-workers-types branch from 125ec90 to f2ea170 Compare April 21, 2026 21:52
@changeset-bot

changeset-bot Bot commented Apr 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c7ffcaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was due to a version mismatch by PR #13615 being merged and later.
PR #13234 had the earlier version of 4.20260420.1 but the version needed
was 4.20260421.1. No tests because this requires workerd CI to test.
@tewaro tewaro force-pushed the tewaro/lockfile-stream-binding-workers-types branch from f2ea170 to c7ffcaf Compare April 21, 2026 21:52
@tewaro tewaro changed the title workers-sdk causing PRs to main to fail workers-sdk causing PRs to workerd main to fail Apr 21, 2026
@tewaro tewaro added the ci:no-tests Skip pull request checks for tests label Apr 21, 2026

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 21, 2026
@edmundhung edmundhung added ci:no-changeset-required Skip pull request checks for a valid changeset ci:skip-pr-description-validation Skip validation of the required PR description format labels Apr 21, 2026
@tewaro tewaro merged commit 2fef357 into main Apr 21, 2026
76 of 89 checks passed
@tewaro tewaro deleted the tewaro/lockfile-stream-binding-workers-types branch April 21, 2026 22:14
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset ci:no-tests Skip pull request checks for tests ci:skip-pr-description-validation Skip validation of the required PR description format

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants