Skip to content

Add experimental secrets property to config validation#12677

Merged
jamesopstad merged 2 commits intomainfrom
james/secrets-property-config
Feb 26, 2026
Merged

Add experimental secrets property to config validation#12677
jamesopstad merged 2 commits intomainfrom
james/secrets-property-config

Conversation

@jamesopstad
Copy link
Contributor

@jamesopstad jamesopstad commented Feb 25, 2026

Add experimental secrets property to config validation.

Not adding to the schema yet so it's hidden


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: experimental feature

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

🦋 Changeset detected

Latest commit: de57ab3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Contributor

claude bot commented Feb 25, 2026

Claude encountered an error —— View job


Changeset Review

Reviewing changeset files...

  • Read changeset guidelines
  • Read and validate .changeset/nine-baths-take.md
  • Check for cute animal image

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 25, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12677

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12677

miniflare

npm i https://pkg.pr.new/miniflare@12677

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12677

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12677

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12677

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12677

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12677

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12677

wrangler

npm i https://pkg.pr.new/wrangler@12677

commit: de57ab3

@jamesopstad jamesopstad marked this pull request as ready for review February 25, 2026 17:52
@jamesopstad jamesopstad requested a review from a team as a code owner February 25, 2026 17:52
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

I just left two minor questions, sorry if these were already discussed 🙇

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Feb 26, 2026
@jamesopstad jamesopstad merged commit eccd014 into main Feb 26, 2026
68 of 81 checks passed
@jamesopstad jamesopstad deleted the james/secrets-property-config branch February 26, 2026 12:08
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants