Skip to content

feat(vite-plugin-cloudflare): disable rsc server handler by default#12535

Merged
petebacondarwin merged 1 commit intomainfrom
edmundhung/rsc-server-handler-false
Feb 11, 2026
Merged

feat(vite-plugin-cloudflare): disable rsc server handler by default#12535
petebacondarwin merged 1 commit intomainfrom
edmundhung/rsc-server-handler-false

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Feb 11, 2026

Fixes n/a.

By default, @vitejs/plugin-rsc adds middleware that imports the RSC entry in Node.js. That doesn't work with cloudflare:* imports and isn't needed anyway since we handle requests through workerd.

Previously, users had to work around this by passing rsc({ serverHandler: false }) themselves. This is now configured by us directly using the rsc config option.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
      I can't find an easy way to setup a rsc playground without coupling with a framework.
      To test this:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: We don't have any docs related to RSC yet.

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2026

🦋 Changeset detected

Latest commit: 076c71a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Contributor

claude bot commented Feb 11, 2026

Claude finished @edmundhung's task —— View job


Changeset Review

  • Read changeset guidelines
  • Read and validate changeset file
  • Check for cute animals
  • Provide feedback

All changesets look good

The changeset is well-structured:

  • Version type: minor is appropriate for a new configuration behavior
  • Description: Clear title and helpful explanation of the change
  • No markdown header issues: Uses no h1/h2/h3 headers
  • User impact: Well-explained with context about the error users were experiencing

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 11, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12535

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12535

miniflare

npm i https://pkg.pr.new/miniflare@12535

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12535

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12535

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12535

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12535

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12535

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12535

wrangler

npm i https://pkg.pr.new/wrangler@12535

commit: 076c71a

@edmundhung edmundhung marked this pull request as ready for review February 11, 2026 19:49
@edmundhung edmundhung requested a review from a team as a code owner February 11, 2026 19:49
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this setting does what you want.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Feb 11, 2026
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a playground or e2e test that shows this working?
I'll test it manually - I just read the PR description 😄

@petebacondarwin
Copy link
Contributor

Yes the manual test demonstrates this fix.

@petebacondarwin petebacondarwin merged commit bd06ad2 into main Feb 11, 2026
45 of 48 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Feb 11, 2026
@petebacondarwin petebacondarwin deleted the edmundhung/rsc-server-handler-false branch February 11, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants