fix(vite-plugin-cloudflare): avoid The WebSocket is undefined error during build#12521
Merged
edmundhung merged 4 commits intomainfrom Feb 11, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: daf9a49 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
|
Claude finished @edmundhung's task —— View job Changeset Review Complete
✅ All changesets look good The changeset for
|
The WebSocket is undefined error during buildThe WebSocket is undefined error during build
jamesopstad
reviewed
Feb 11, 2026
packages/vite-plugin-cloudflare/playground/spa-with-api/vite.config.child-compiler.ts
Outdated
Show resolved
Hide resolved
...vite-plugin-cloudflare/playground/spa-with-api/__tests__/child-compiler/spa-with-api.spec.ts
Show resolved
Hide resolved
79d3988 to
7ba4fbc
Compare
jamesopstad
approved these changes
Feb 11, 2026
0033b99 to
6cad633
Compare
6cad633 to
daf9a49
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8909.
CloudflareDevEnvironmentrequiresinitRunner()to be called via the dev plugin'sconfigureServerhook to establish its WebSocket connection.Frameworks like React Router create a child Vite dev server during builds to compile route files, and strip configureServer from all plugins to avoid conflicts. This means
initRunner()never runs, leaving the WebSocket uninitialized. When Vite's dep optimizer or module pruning callshot.send(), the assertion fails.The fix checks whether
configureServeris still present on the dev plugin at environment creation time. If it's been stripped, we fall back to a standard vite environment.A picture of a cute animal (not mandatory, but encouraged)