[Wrangler/Workflows] Add warning on deploy of workflows belonging to other workers#12513
[Wrangler/Workflows] Add warning on deploy of workflows belonging to other workers#12513pombosilva merged 6 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 9501405 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @pombosilva's task —— View job Changeset ReviewTodo List:
✅ All changesets look good The changeset file
The changeset properly describes the new confirmation prompt behavior and helpfully explains the non-interactive/ Cuteness Report: This is Nemo (probably). Vibing in their pink palace with absolutely no sense of personal space. Peak "just keep swimming" energy. The coral looks thrilled. 14/10 would definitely get stung trying to pet. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
LuisDuarte1
left a comment
There was a problem hiding this comment.
LGTM from the workflows team 🚀
7daeb99 to
9f34f31
Compare
packages/wrangler/src/__tests__/deploy/check-workflow-conflicts.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/deploy/check-workflow-conflicts.test.ts
Outdated
Show resolved
Hide resolved
vicb
left a comment
There was a problem hiding this comment.
I added a few inline comments
9f45be4 to
d69d350
Compare
packages/wrangler/src/__tests__/deploy/check-workflow-conflicts.test.ts
Outdated
Show resolved
Hide resolved
vicb
left a comment
There was a problem hiding this comment.
LGTM, thanks for the update
27a679e to
9501405
Compare
Fixes WOR-1157.
Adds a confirmation prompt when
wrangler deploydetects that a workflow being deployed already exists and belongs to a different worker. This prevents accidental overwrites of workflows between workers./accounts/{accountId}/workflowsAPI before deploymentExample Output:
A picture of a cute animal (not mandatory, but encouraged)
