Skip to content

[create-cloudflare] Quarantine Qwik E2E tests (upstream eslint conflict)#12475

Merged
vicb merged 4 commits intomainfrom
devin/1770476028-fix-qwik-eslint-dep
Feb 8, 2026
Merged

[create-cloudflare] Quarantine Qwik E2E tests (upstream eslint conflict)#12475
vicb merged 4 commits intomainfrom
devin/1770476028-fix-qwik-eslint-dep

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin commented Feb 7, 2026 •
edited by devin-ai-integration Bot
Loading

Relates to failing CI run: https://github.com/cloudflare/workers-sdk/actions/runs/21779975611/job/62842418743?pr=12454

Background and root cause
The Qwik CLI ([email protected]) scaffolds projects with @eslint/js set to "latest" in devDependencies. This recently started resolving to @eslint/[email protected], which declares peerOptional eslint@"^10.0.0". Since the generated project also pins [email protected], npm install fails with an ERESOLVE peer dependency conflict, causing the Qwik framework E2E tests to fail.

Updates since last revision

  • Reverted the C3 Qwik template changes (no longer pinning @eslint/js in generated projects).
  • Quarantined Qwik framework tests:
    • Added quarantine: true to qwik:pages and both qwik:workers entries (non-experimental and experimental) in e2e/frameworks test config.
  • Removed the changeset that corresponded to the now-reverted C3 change.
  • Intention: keep C3 logic unchanged and skip Qwik E2E tests until the upstream issue is fixed (e.g. Qwik stops using "latest" for @eslint/js or we adopt eslint@^10).

Diff summary

  • e2e: Set quarantine: true for:
    • qwik:pages
    • qwik:workers (in both framework lists)
  • Reverted template modifications in:
    • packages/create-cloudflare/templates/qwik/pages/c3.ts
    • packages/create-cloudflare/templates/qwik/workers/c3.ts
  • Deleted .changeset/fix-qwik-eslint-dep.md (no user-facing change now)

Follow-up plan

  • Track upstream resolution and re-enable Qwik tests by removing quarantine: true.
  • If needed later, consider a separate targeted change with maintainers’ approval.

Devin PR requested by [email protected]
Link to Devin run: https://app.devin.ai/sessions/cd621af804534520b84576eea09116fb

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this change only quarantines internal E2E tests and reverts a prior internal code change; no user-facing behavior or APIs changed
Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 7, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9e9cc77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration
Copy link
Copy Markdown
Contributor

devin-ai-integration Bot commented Feb 7, 2026

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Feb 7, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 7, 2026 •
edited
Loading

Claude finished @petebacondarwin's task —— View job

Changeset Review

Reviewing changeset file...

Tasks:

  • Read changeset guidelines
  • Read changeset file
  • Validate changeset
  • Check for cute animals

Review Result

✅ All changesets look good

The changeset .changeset/quarantine-qwik-tests.md meets all requirements:

  • ✅ Version type: patch is appropriate for test infrastructure changes
  • ✅ Changelog quality: Clear description with bullet points explaining what's being disabled and why
  • ✅ No h1/h2/h3 headers used
  • ✅ No analytics changes
  • ✅ Not a dependabot PR
  • ✅ No experimental features involved

The changeset correctly documents that this is an internal testing change with no user-facing behavior changes, which is exactly what a patch should communicate for this type of change.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 7, 2026 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12475

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12475

miniflare

npm i https://pkg.pr.new/miniflare@12475

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12475

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12475

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12475

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12475

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12475

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12475

wrangler

npm i https://pkg.pr.new/wrangler@12475

commit: 9e9cc77

@petebacondarwin
Copy link
Copy Markdown
Contributor Author

petebacondarwin commented Feb 7, 2026

Not sure if it is best to fix this here or just disable these tests until Qwik fixes it upstream (QwikDev/qwik#8308)?

@MattieTK MattieTK mentioned this pull request Feb 7, 2026
Merged
5 tasks
@vicb
Copy link
Copy Markdown
Contributor

vicb commented Feb 7, 2026

Not sure if it is best to fix this here or just disable these tests until Qwik fixes it upstream (QwikDev/qwik#8308)?

I think we should disable the tests for now in order to land all the awesome PRs that are blocked by the failing CI currently.

@devin-ai-integration devin-ai-integration Bot changed the title [create-cloudflare] Fix Qwik project creation failing due to @eslint/js dependency conflict [create-cloudflare] Quarantine Qwik E2E tests (upstream eslint conflict) Feb 8, 2026
@petebacondarwin petebacondarwin marked this pull request as ready for review February 8, 2026 11:11
@petebacondarwin petebacondarwin requested a review from a team as a code owner February 8, 2026 11:11
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Feb 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 8, 2026
@vicb vicb merged commit c0b6152 into main Feb 8, 2026
40 of 41 checks passed
@vicb vicb deleted the devin/1770476028-fix-qwik-eslint-dep branch February 8, 2026 13:50
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 8, 2026
@petebacondarwin petebacondarwin mentioned this pull request Mar 6, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@vicb vicb vicb approved these changes

Assignees

@petebacondarwin petebacondarwin

Labels

no-changeset-required

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@petebacondarwin @vicb @workers-devprod