[create-cloudflare] Quarantine Qwik E2E tests (upstream eslint conflict)#12475
[create-cloudflare] Quarantine Qwik E2E tests (upstream eslint conflict)#12475
Conversation
…js dependency conflict Co-Authored-By: [email protected] <[email protected]>
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Claude finished @petebacondarwin's task —— View job Changeset ReviewReviewing changeset file... Tasks:
Review Result✅ All changesets look good The changeset
The changeset correctly documents that this is an internal testing change with no user-facing behavior changes, which is exactly what a patch should communicate for this type of change. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Not sure if it is best to fix this here or just disable these tests until Qwik fixes it upstream (QwikDev/qwik#8308)? |
I think we should disable the tests for now in order to land all the awesome PRs that are blocked by the failing CI currently. |
… C3 Qwik template changes; remove changeset Co-Authored-By: [email protected] <[email protected]>
@eslint/js dependency conflict…el for test-only change Co-Authored-By: [email protected] <[email protected]>
Relates to failing CI run: https://github.com/cloudflare/workers-sdk/actions/runs/21779975611/job/62842418743?pr=12454
Background and root cause
The Qwik CLI (
[email protected]) scaffolds projects with@eslint/jsset to"latest"indevDependencies. This recently started resolving to@eslint/[email protected], which declarespeerOptional eslint@"^10.0.0". Since the generated project also pins[email protected],npm installfails with anERESOLVEpeer dependency conflict, causing the Qwik framework E2E tests to fail.Updates since last revision
@eslint/jsin generated projects).quarantine: truetoqwik:pagesand bothqwik:workersentries (non-experimental and experimental) in e2e/frameworks test config."latest"for@eslint/jsor we adopteslint@^10).Diff summary
quarantine: truefor:qwik:pagesqwik:workers(in both framework lists)packages/create-cloudflare/templates/qwik/pages/c3.tspackages/create-cloudflare/templates/qwik/workers/c3.ts.changeset/fix-qwik-eslint-dep.md(no user-facing change now)Follow-up plan
quarantine: true.Devin PR requested by [email protected]
Link to Devin run: https://app.devin.ai/sessions/cd621af804534520b84576eea09116fb