Wrangler: add Pages detection to autoconfig flows#12382
Merged
dario-piotrowicz merged 7 commits intomainfrom Feb 10, 2026
Merged
Wrangler: add Pages detection to autoconfig flows#12382dario-piotrowicz merged 7 commits intomainfrom
dario-piotrowicz merged 7 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 1e12592 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Claude finished @dario-piotrowicz's task —— View job Changeset Review
✅ All changesets look good The changeset in
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
dario-piotrowicz
force-pushed
the
dario/DEVX-2439/autoconfig-pages-detection
branch
from
837b93d to
9afe921
Compare
emily-shen
reviewed
Feb 4, 2026
emily-shen
reviewed
Feb 5, 2026
| if (existsSync(functionsPath)) { | ||
| const functionsStat = statSync(functionsPath); | ||
| if (functionsStat.isDirectory()) { | ||
| const pagesConfirmed = await confirm( |
Contributor
There was a problem hiding this comment.
just to double check, will this auto-accept in CI?
Member
Author
There was a problem hiding this comment.
yes it will... confirming that the project is a Pages one and then erroring...
I guess we should auto-deny instead... in that case CI would proceed (even though that might also be incorrect)...? 🤔
what do you think?
Contributor
There was a problem hiding this comment.
oh sorry i got confused 😅
i think the behaviour in CI needs to proceed with a folder called functions to avoid breaking anyone. sorry i know its a bit of an edgecase!
MattieTK
requested changes
Feb 6, 2026
dario-piotrowicz
force-pushed
the
dario/DEVX-2439/autoconfig-pages-detection
branch
from
47e64aa to
7b951c2
Compare
dario-piotrowicz
force-pushed
the
dario/DEVX-2439/autoconfig-pages-detection
branch
from
7b951c2 to
6fc4329
Compare
dario-piotrowicz
force-pushed
the
dario/DEVX-2439/autoconfig-pages-detection
branch
from
f316834 to
7f905bf
Compare
dario-piotrowicz
force-pushed
the
dario/DEVX-2439/autoconfig-pages-detection
branch
from
bdc09c3 to
008187d
Compare
…es when there is no out-dir
MattieTK
approved these changes
Feb 10, 2026
emily-shen
approved these changes
Feb 10, 2026
dario-piotrowicz
deleted the
dario/DEVX-2439/autoconfig-pages-detection
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.cfdata.org/browse/DEVX-2439
When running the autoconfig logic (via
wrangler setup,wrangler deploy --x-autoconfig, or the programmatic autoconfig API), Wrangler now detects when a project appears to be a Pages project and handles it appropriately:wrangler deploy, it warns the user but still allows them to proceedwrangler setupand the programmatic autoconfig API, it throws a fatal errorA picture of a cute animal (not mandatory, but encouraged)