Skip to content

[wrangler] Add deprecation warning for queue delivery_delay#12279

Draft
penalosa wants to merge 6 commits intomainfrom
fix/10286-queue-delivery-delay-warning
Draft

[wrangler] Add deprecation warning for queue delivery_delay#12279
penalosa wants to merge 6 commits intomainfrom
fix/10286-queue-delivery-delay-warning

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Jan 29, 2026

Part of #10286.

The delivery_delay setting in [[queues.producers]] was silently having no effect since PR #10288 removed the functionality that used it. This PR adds a deprecation warning when the setting is used, informing users that queue-level settings should be configured using wrangler queues update instead.

Changes

  • Added deprecation warning in validateQueueBinding function when delivery_delay is set
  • Added test case for the new deprecation warning
  • Added changeset for the patch release

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: This is a deprecation warning that guides users to use wrangler queues update instead, which is already documented.

Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2026

🦋 Changeset detected

Latest commit: a4530f1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Contributor

claude bot commented Jan 29, 2026

Claude finished @penalosa's task —— View job


Changeset Review

  • Read changeset guidelines
  • Review changeset file
  • Check attached image
  • Validate against criteria

All changesets look good

The changeset for .changeset/deprecate-queue-delivery-delay.md passes all validation criteria:

  1. Version Type: patch is correct for a deprecation warning
  2. Changelog Quality: Clear description explaining what was deprecated, why, and what users should do instead
  3. Markdown Headers: No h1/h2/h3 headers used
  4. Analytics: Not applicable (no analytics changes)
  5. Dependabot: Not applicable
  6. Experimental features: Not applicable

The changeset properly documents that delivery_delay in queue producer bindings has been deprecated, explains it had no effect since 2024, and directs users to use wrangler queues update instead.


@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 29, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12279

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12279

miniflare

npm i https://pkg.pr.new/miniflare@12279

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12279

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12279

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12279

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12279

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12279

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12279

wrangler

npm i https://pkg.pr.new/wrangler@12279

commit: a4530f1

@penalosa penalosa marked this pull request as ready for review January 29, 2026 17:42
@penalosa penalosa requested a review from a team as a code owner January 29, 2026 17:42
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional flags.

Open in Devin Review

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View issue and 5 additional flags in Devin Review.

Open in Devin Review

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOTM, added some comments

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jan 29, 2026
@penalosa
Copy link
Contributor Author

@claude can you make checks and tests pass

@claude
Copy link
Contributor

claude bot commented Jan 30, 2026

Claude finished @penalosa's task —— View job


Todo List:

  • Read the failing test and validation code files
  • Fix the message mismatch between test expectation and actual code
  • Address review comments and suggestions
  • Commit and push changes

Changes Made:

  1. Fixed test failure: Updated warning message in packages/workers-utils/src/config/validation.ts:3535-3537 to match test expectation:

    • "Queue settings" → "Queue-level settings"
    • "in the next major version" → "in a future version"
  2. Addressed review feedback: Updated .changeset/deprecate-queue-delivery-delay.md per vicb's comment:

The changes have been committed and pushed to fix the failing checks and tests. The warning message now aligns with the test expectation, and the changeset description has been improved per review feedback.


@petebacondarwin petebacondarwin force-pushed the fix/10286-queue-delivery-delay-warning branch from 120fcbd to bfb187a Compare February 3, 2026 19:59
@petebacondarwin
Copy link
Contributor

@claude the formatting needs fixing - perhaps by running pnpm fix.

@claude
Copy link
Contributor

claude bot commented Feb 3, 2026

Claude finished @petebacondarwin's task —— View job


Fixing Formatting Issues

Todo List:

  • Run pnpm fix to fix formatting issues
  • Check what files were changed
  • Commit and push any formatting fixes

The git working tree is clean, which means there are currently no uncommitted formatting issues. However, since you mentioned formatting needs fixing, there might be formatting violations that would be caught by CI checks.

I don't have permission to run pnpm fix directly. You'll need to run this command locally:

pnpm fix

This will auto-fix any linting and formatting issues, then you can commit and push the changes. Alternatively, you could add the --allowedTools=Bash(pnpm*) permission to let me run pnpm commands directly.


@petebacondarwin petebacondarwin marked this pull request as draft February 4, 2026 13:50
penalosa and others added 6 commits February 4, 2026 13:51
The delivery_delay setting in [[queues.producers]] was silently having no effect
since PR #10288 removed the functionality. This adds a deprecation warning to inform
users that queue-level settings should be configured using 'wrangler queues update'
instead.

Fixes #10286
- Align warning message with test expectation
- Update changeset description per review feedback

Co-authored-by: Somhairle MacLeòid <[email protected]>
@petebacondarwin petebacondarwin force-pushed the fix/10286-queue-delivery-delay-warning branch from bfb187a to a4530f1 Compare February 4, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

3 participants