Fix potential EBADF error when restarting workerd process in Miniflare#12025
Merged
petebacondarwin merged 2 commits intomainfrom Feb 11, 2026
Merged
Fix potential EBADF error when restarting workerd process in Miniflare#12025petebacondarwin merged 2 commits intomainfrom
petebacondarwin merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: f97d99b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
vicb
reviewed
Jan 21, 2026
vicb
reviewed
Jan 21, 2026
vicb
reviewed
Jan 21, 2026
petebacondarwin
force-pushed
the
fix-miniflare-runtime-ebadf-on-restart
branch
from
d9ed3ad to
4e3ee2d
Compare
Contributor
|
Claude finished @petebacondarwin's task —— View job Changeset Review✅ All changesets look good The changeset for this PR follows all guidelines:
Cuteness Report: This is... an orange dot. Might be a distant planet or maybe a freckle with stage presence. Either way, not really delivering on the animal content. Still bold enough to show up though. 6/10 for effort. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Explicitly destroy all stdio streams (stdin, stdout, stderr, and control pipe) before killing the workerd process in Runtime#dispose(). This ensures file descriptors are properly released before spawning a new process, preventing EBADF errors during rapid restarts. Fixes #11675
petebacondarwin
force-pushed
the
fix-miniflare-runtime-ebadf-on-restart
branch
from
4e3ee2d to
f97d99b
Compare
jamesopstad
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly destroy all stdio streams (stdin, stdout, stderr, and control pipe) before killing the workerd process in Runtime#dispose(). This ensures file descriptors are properly released before spawning a new process, preventing EBADF errors during rapid restarts.
The original issue was not able to provide a reproduction that we could test so this PR is speculative.
Fixes #11675
A picture of a cute animal (not mandatory, but encouraged)