fix: DB reconnect when re-using runtime#11111
Conversation
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Looks like these test failures were fixed in #11300. |
Fix for cloudflare#9913 and cloudflare#10506 Based on diagnosis in cloudflare#9913 (comment)
f3c2871 to
becdd8d
Compare
| } else { | ||
| log.debug(`Reusing runtime for ${project.relativePath}...`); | ||
| // Set same options to reset DB connections | ||
| await forEachMiniflare(project.mf, (mf) => mf.setOptions(mfOptions)); |
There was a problem hiding this comment.
I don't think we should land this as it is since it then makes it the same as when there are changes.
|
This is not really the right approach to fixing the problem. |
Fixes #9913 , #10506
Adapted from comment by @SyedRFarhan, #9913 (comment)
This doesn't yet have tests. I'm not sure it's the right approach so looking for feedback before investing further.