switch zone route warning to an info message#10761
Merged
petebacondarwin merged 1 commit intomainfrom Oct 1, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 7f760e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
force-pushed
the
pbd/switch-zone-warning-to-infio
branch
from
cd54693 to
472938d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
petebacondarwin
force-pushed
the
pbd/switch-zone-warning-to-infio
branch
from
472938d to
7f760e3
Compare
edmundhung
approved these changes
Sep 30, 2025
Comment on lines
1540
to
1552
| expect(std.err).toMatchInlineSnapshot(`""`); | ||
| expect(std.warn).toMatchInlineSnapshot(` | ||
| "[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1mThe current authentication token does not have 'All Zones' permissions.[0m | ||
|
|
||
| Falling back to using the zone-based API endpoint to update each route individually. | ||
| Note that there is no access to routes associated with zones that the API token does not have | ||
| permission for. | ||
| Existing routes for this Worker in such zones will not be deleted. | ||
|
|
||
|
|
||
| [33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1mPreviously deployed routes:[0m | ||
| "[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1mPreviously deployed routes:[0m | ||
|
|
||
| The following routes were already associated with this worker, and have not been deleted: |
Member
There was a problem hiding this comment.
Should we add a snapshot test for std.info?
Contributor
Author
There was a problem hiding this comment.
Doh! I merged this too soon. Yes you are right.
Merged
petebacondarwin
added a commit
that referenced
this pull request
Oct 2, 2025
edmundhung
pushed a commit
that referenced
this pull request
Oct 2, 2025
* switch zone route warning to an info message * relax request content type check * fixup! switch zone route warning to an info message
petebacondarwin
added a commit
that referenced
this pull request
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10751