Skip to content

BACKPORT #10668 - wrangler: fix: support the deletion of secrets with complex names#10760

Merged
petebacondarwin merged 1 commit intov3-maintenancefrom
v3-backport-10668
Sep 26, 2025
Merged

BACKPORT #10668 - wrangler: fix: support the deletion of secrets with complex names#10760
petebacondarwin merged 1 commit intov3-maintenancefrom
v3-backport-10668

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Sep 25, 2025

URL encode the secret names before being sent to the API, should allow users to delete secrets with complex names. Change is still compatible with older Wrangler versions thanks to the optional query param flag url_encoded.

Backport for #10668

@petebacondarwin petebacondarwin requested a review from a team as a code owner September 25, 2025 14:15
@petebacondarwin petebacondarwin added skip-pr-description-validation Skip validation of the required PR description format v3-backport The PR is a v3 backport targetting the v3-maintenance branch labels Sep 25, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025

🦋 Changeset detected

Latest commit: f8d8058

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

URL encode the secret names before being sent to the API, should allow
users to delete secrets with complex names. Change is still compatible
with older Wrangler versions thanks to the optional query param flag
`url_encoded`.
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 26, 2025
@petebacondarwin petebacondarwin merged commit cb7ace5 into v3-maintenance Sep 26, 2025
16 of 17 checks passed
@petebacondarwin petebacondarwin deleted the v3-backport-10668 branch September 26, 2025 13:25
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-pr-description-validation Skip validation of the required PR description format v3-backport The PR is a v3 backport targetting the v3-maintenance branch

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants