allow WRANGLER_SEND_ERROR_REPORTS to override whether to report Wrangler crashes to Sentry#10735
Conversation
🦋 Changeset detectedLatest commit: d1d268d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
force-pushed
the
pbd/add-no-sentry-env-var
branch
4 times, most recently
from
b1728b2 to
0070ce4
Compare
petebacondarwin
force-pushed
the
pbd/add-no-sentry-env-var
branch
from
0070ce4 to
71e0b1c
Compare
…gler crashes to Sentry
petebacondarwin
force-pushed
the
pbd/add-no-sentry-env-var
branch
from
71e0b1c to
d1d268d
Compare
petebacondarwin
changed the title
edmundhung
left a comment
edmundhung
left a comment
There was a problem hiding this comment.
Approved with a few nits.
We probably want to update the docs for the new env var as well.
| event_id: "", | ||
| sdk: { | ||
| name: "sentry.javascript.node", | ||
| version: "7.87.0", |
There was a problem hiding this comment.
This will require us to update the test when ever we update the sentry client. Would it be better to match it with expect.any(String) instead?
There are a few more version number above.
| sent_at: "", | ||
| trace: { | ||
| environment: "production", | ||
| public_key: "9edbb8417b284aa2bbead9b4c318918b", |
There was a problem hiding this comment.
Looks like a magic number that could change? Maybe match it with expect.any(String) as well?
| sent_at: "", | ||
| trace: { | ||
| environment: "production", | ||
| public_key: "9edbb8417b284aa2bbead9b4c318918b", |
There was a problem hiding this comment.
| public_key: "9edbb8417b284aa2bbead9b4c318918b", | |
| public_key: expect.any(String), |
| event_id: "", | ||
| sdk: { | ||
| name: "sentry.javascript.node", | ||
| version: "7.87.0", |
There was a problem hiding this comment.
| version: "7.87.0", | |
| version: expect.any(String), |
| version: "7.87.0", | ||
| }, | ||
| ], | ||
| version: "7.87.0", |
There was a problem hiding this comment.
| version: "7.87.0", | |
| version: expect.any(String), |
| packages: [ | ||
| { | ||
| name: "npm:@sentry/node", | ||
| version: "7.87.0", |
There was a problem hiding this comment.
| version: "7.87.0", | |
| version: expect.any(String), |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "wrangler": patch | |||
There was a problem hiding this comment.
Is this a fix or new feature? 🤔
There was a problem hiding this comment.
I'll bump it to minor
|
Thanks for the review @edmundhung - the new Sentry test is an exact copy of another test in that file. So there is no new reliance upon magic constants that wasn't there before. We can improve that in another PR, but so far it seems that we have rarely been bothered by it - perhaps because there has not been any update to that dependency in a long time? |
|
Created a docs PR: cloudflare/cloudflare-docs#25605 |
…hether to report Wrangler crashes to Sentry (#10737) * allow WRANGLER_SEND_METRICS to override whether to report Wrangler crashes to Sentry * fixup! allow WRANGLER_SEND_METRICS to override whether to report Wrangler crashes to Sentry --------- Co-authored-by: Peter Bacon Darwin <[email protected]>
2 participants
Fixes #10719