Skip to content

fix NonRetryableError thrown with an empty error message not stopping workflow retries locally#10219

Merged
petebacondarwin merged 1 commit intomainfrom
dario/empry-nonretryiableerror
Aug 11, 2025
Merged

fix NonRetryableError thrown with an empty error message not stopping workflow retries locally#10219
petebacondarwin merged 1 commit intomainfrom
dario/empry-nonretryiableerror

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Aug 4, 2025

Fixes #10113


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix
  • Wrangler V3 Backport

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025

🦋 Changeset detected

Latest commit: 84a9a08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cloudflare/workflows-shared Patch
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 4, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10219

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10219

miniflare

npm i https://pkg.pr.new/miniflare@10219

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10219

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10219

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10219

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10219

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10219

wrangler

npm i https://pkg.pr.new/wrangler@10219

commit: 84a9a08

@dario-piotrowicz dario-piotrowicz force-pushed the dario/empry-nonretryiableerror branch from 77d7128 to 84a9a08 Compare August 4, 2025 23:56
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review August 5, 2025 09:27
@dario-piotrowicz dario-piotrowicz requested review from a team as code owners August 5, 2025 09:27
Copy link
Contributor

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from the workflows team, ty :)

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 5, 2025
@dario-piotrowicz
Copy link
Member Author

Thanks for the review @LuisDuarte1 🫶

@petebacondarwin petebacondarwin merged commit 28494f4 into main Aug 11, 2025
56 of 61 checks passed
@petebacondarwin petebacondarwin deleted the dario/empry-nonretryiableerror branch August 11, 2025 07:50
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Cloudflare Workflow retries on NonRetryableError in dev mode

3 participants