Merged
Conversation
9 tasks
Deploying cloudflare-docs with
|
| Latest commit: |
b88b6e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7da55866.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://walshy-mounted-assets.cloudflare-docs-7ou.pages.dev |
Contributor
Contributor
irvinebroque
left a comment
There was a problem hiding this comment.
interesting that this is something that also wasn't possible with Pages - right?
I can have a custom domain with a Pages project.
But I can't define a route to say — run the Pages project at /blog.
And so here, I can just run the Worker, and its assets at /blog — that was already possible.
But before — if I had /blog directory, and ran the Worker on the /blog route, to access /dist/blog/index.html I would have to go to example.com/blog/blog
And now just example.com/blog
Is that accurate before/after?
Contributor
|
Or did we just disallow mounting assets on a route before |
Cherry
reviewed
Dec 11, 2024
GregBrimble
reviewed
Dec 11, 2024
GregBrimble
reviewed
Dec 11, 2024
GregBrimble
reviewed
Dec 11, 2024
GregBrimble
reviewed
Dec 11, 2024
GregBrimble
reviewed
Dec 11, 2024
GregBrimble
reviewed
Dec 11, 2024
fc45612 to
50612e7
Compare
50612e7 to
b88b6e0
Compare
WillTaylorDev
approved these changes
Dec 20, 2024
korinne
approved these changes
Dec 20, 2024
Contributor
korinne
left a comment
There was a problem hiding this comment.
Looks great, thanks so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents mounting assets on a given path and the behaviour of it.
Note: Waiting on Wrangler to go out
Screenshots (optional)
Documentation checklist