Skip to content

Conversation

@mitch292
Copy link
Contributor

@mitch292 mitch292 commented Feb 8, 2025

This reverts commit 1a73d78.

The certificate we'd like to remove that is expiring is still present on the latest version of the package.

Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number: 1 (0x1)
        Signature Algorithm: sha1WithRSAEncryption
        Issuer: C=US, O=Apple Computer, Inc., OU=Apple Computer Certificate Authority, CN=Apple Root Certificate Authority
        Validity
            Not Before: Feb 10 00:18:14 2005 GMT
            Not After : Feb 10 00:18:14 2025 GMT
        Subject: C=US, O=Apple Computer, Inc., OU=Apple Computer Certificate Authority, CN=Apple Root Certificate Authority

This certificate can still be found here on latest of certificate-transparency-go - https://github.com/google/certificate-transparency-go/blob/master/x509/root_darwin_armx.go#L364 - so this previous commit was unnecessary and did not achieve the purpose of removing an expired certificate from the code base.

@mitch292 mitch292 self-assigned this Feb 8, 2025
@mitch292 mitch292 merged commit 730ee58 into cloudflare:master Feb 10, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant