Remove binary file and update Makefile#16
Merged
gabriel-samfira merged 2 commits intocloudbase:mainfrom Jul 19, 2025
Merged
Conversation
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Member
|
🤦 Thank you! I should have noticed before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While updating to
garm-provider-lxd0.1.1 I noticed that the repo contains a binary file for version 0.1.0 (which I assume was accidentally committed). This PR removes that file again.Also I noticed that we build to the repos root directory, instead of
bin/, which is already in.gitignoreand also covered bymake clean. So the binaries will now be build inbin/. Alternatively we could addgarm-provider-lxdto.gitignore...