Skip to content

fix: use a global replace to join multiple line Vensim equations in comments #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrispcampbell merged 2 commits into from
Apr 4, 2022
Merged

fix: use a global replace to join multiple line Vensim equations in comments #175

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
064ca34
use a global replace to join multiple line Vensim equations in comments
ToddFincannon Mar 19, 2022
5319a9b
test: add test case that has multiple line breaks to reproduce issue
chrispcampbell Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EquationGen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export default class EquationGen extends ModelReader {
return this.generateLookup()
}
// Show the model var as a comment for reference.
this.comments.push(` // ${this.var.modelLHS} = ${this.var.modelFormula.replace('\n', '')}`)
this.comments.push(` // ${this.var.modelLHS} = ${this.var.modelFormula.replace(/\n/g, '')}`)
// Emit direct constants individually without separating them first.
if (this.var.directConstArgs) {
return this.generateDirectConstInit()
Expand Down