-
Notifications
You must be signed in to change notification settings - Fork 958
Add docs for Android components #2848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
6620a5b to
169ed35
Compare
|
169ed35 to
097ff9e
Compare
|
097ff9e to
d5f5109
Compare
|
|
manovotny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @swolfand and @SarahSoutoul!
Just a couple of small questions/comments.
Co-authored-by: Michael Novotny <manovotny@gmail.com>
Co-authored-by: Michael Novotny <manovotny@gmail.com>
|
@swolfand following our meeting today, I've submitted a last commit with fixes: docs review pt2. Have a look and let me know if anything doesn't look right. |
|
@SarahSoutoul looks great to me! |
|
@manovotny have committed your suggestions and pushed some last commits after a call with Sam. I'm good to approve this, and it will only be merged after the actual Android SDK changes have been released. But be good to have your approval too on this in case I missed anything. |
Co-authored-by: Michael Novotny <manovotny@gmail.com>
manovotny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
also LGTM! didn't test the code as i believe sarah did this with sam - but everything looks like perfection 😸💖 |
Yes we tested everything together on a call! |
🔎 Previews:
This pull request adds comprehensive documentation for Clerk's Android UI components and customization options. It introduces reference pages for the main Clerk Android views, explains how to customize them using the new
ClerkThemesystem, and clarifies installation and usage patterns for the Clerk Android SDK. The changes are grouped into new documentation for Android views, detailed theming and customization guides, and updates to component reference listings.Android Views Documentation
AuthView,UserButton, andUserProfileView, including usage examples, parameter descriptions, and customization instructions. [1] [2] [3]Theming and Customization
ClerkTheme, detailing color, typography, and design properties, as well as usage examples for global and per-view theming.Component Reference Updates
androidfrom the SDK list, ensuring correct categorization and navigation.