Merged
Conversation
Member
Author
|
We can merge this or not, but it provides a proof of concept that we could do this. I think this may help a lot with more complex testing, such as with the adjoint tests, and help with the use of alternative setrun.py files from arbitrary locations. |
mandli
force-pushed
the
new-pytest-test-runner
branch
from
a00219b to
220dfca
Compare
Member
Author
|
Moved the generic code for the test runner into clawutil now, see clawpack/clawutil#96 for details. |
Also adds more comments to the example test in acoustics_1d_heterogenous.
This brings up to date testing for classic with what was done in GeoClaw. This currently does not have any python tests, and if they are added, the testing.yml would need to be updated. There's also no slow test functionality.
Member
|
Looks good and have discussed with @mandli. I'll merge this one, and also in amrclaw, geoclaw , so we can move forward. |
This was referenced Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way we are doing testing on a larger scale and adds some new capabilities:
pytestmore directly than the previous tests based onUnitTestpytest --basetemp=setrunis used by path and removes problems with collision of namespytestfixtures to provide other functionality meaning that they can also be expandedThere are a number of other advantages to this approach including using other plugins for PyTest in the future.