RO Feedback

[matyaskopp]

meeting element

• extend meeting elements (#parla.term, #parla.sitting)

I haven't found any information about terms or sitting in the meeting elements. This is how other corpora implement it:

ParlaMint/Data/ParlaMint-UA/ParlaMint-UA_2014-12-02-m0.xml

Lines 11 to 13 in 197e5ec

	<meeting ana="#parla.term #parla.uni" n="8" corresp="#ВРУ">8</meeting>
	<meeting ana="#parla.session #parla.uni" n="1" corresp="#ВРУ">1</meeting>
	<meeting ana="#parla.sitting #parla.uni" n="2014-12-02" corresp="#ВРУ">2014-12-02</meeting>

I was not able to find term info on Romanian parliament websites - I believe the information is there.
And if a single file contains one sitting, then add sitting identification.

Missing speech content

• speech content

In some files there is no speech content:
https://github.com/romanian-parlamint/ParlaMint/blob/8439dd75ca3c31b89f06bac23eff736a72a6ed6a/Data/ParlaMint-RO/ParlaMint-RO_2000-09-04-id4959.xml

        <note type="time">Şedinţa a început la ora 15,55.</note>
        <note type="chairman">Lucrările au fost conduse de domnul Ion Diaconescu, preşedintele Camerei Deputaţilor, asistat de domnii Andrei Ioan Chiliman şi Acsinte Gaspar, secretari.</note>
        <note type="speaker">Domnul Ion Diaconescu:</note>
        <u ana="#chair" who="#Ion-Diaconescu" xml:id="ParlaMint-RO_2000-09-04-id4959.u1"/>
        <note type="speaker">Domnul Iuliu Ioan Furo:</note>

but the source contains speech contents:
https://www.cdep.ro/pls/steno/steno2015.stenograma?ids=4959&idl=1#S0

Chairman note type

• use narrative or president
  According to doc, narrative or president fits better in this case:
  https://github.com/romanian-parlamint/ParlaMint/blob/8439dd75ca3c31b89f06bac23eff736a72a6ed6a/Data/ParlaMint-RO/ParlaMint-RO_2000-09-04-id4959.xml#L125

        <note type="chairman">Lucrările au fost conduse de domnul Ion Diaconescu, preşedintele Camerei Deputaţilor, asistat de domnii Andrei Ioan Chiliman şi Acsinte Gaspar, secretari.</note>

not recognized notes

• notes in text

Notes are in source italics so easy to recognize...

https://github.com/romanian-parlamint/ParlaMint/blob/8439dd75ca3c31b89f06bac23eff736a72a6ed6a/Data/ParlaMint-RO/ParlaMint-RO_2000-04-14-id4927.xml#L474

<seg xml:id="ParlaMint-RO_2000-04-14-id4927.u39.seg6">Cine este pentru?(Vociferără în partea dreaptă a sălii).Vă rog să număraţi... Vă rog să ridicaţi mâna, cei care sunteţi pentru acest amendament, să repetăm numărătoarea. Este o confuzie.</seg>

should be: (https://clarin-eric.github.io/ParlaMint/#TEI.vocal)

<seg xml:id="ParlaMint-RO_2000-04-14-id4927.u39.seg6">Cine este pentru? <vocal type="shouting">
    <desc>(Vociferără în partea dreaptă a sălii)</desc>
  </vocal> Vă rog să număraţi... Vă rog să ridicaţi mâna, cei care sunteţi pentru acest amendament, să repetăm numărătoarea. Este o confuzie.</seg>

presence list

• presence list is missing status

https://github.com/romanian-parlamint/ParlaMint/blob/8439dd75ca3c31b89f06bac23eff736a72a6ed6a/Data/ParlaMint-RO/ParlaMint-RO_2000-04-14-id4927.xml#L510-L513

        <u ana="#regular" who="#Andrei-Ioan-Chiliman" xml:id="ParlaMint-RO_2000-04-14-id4927.u46">
          <seg xml:id="ParlaMint-RO_2000-04-14-id4927.u46.seg1">Achimescu Victor Ştefan</seg>
          <seg xml:id="ParlaMint-RO_2000-04-14-id4927.u46.seg2">Aferăriţei Constantin</seg>
          <seg xml:id="ParlaMint-RO_2000-04-14-id4927.u46.seg3">Afrăsinei Viorica</seg>

corpus timespan

• corpus timespan bibl
• corpus timespan setting
• corpus timespan it would be nice to have it in text content of corpus title too

https://github.com/romanian-parlamint/ParlaMint/blob/8439dd75ca3c31b89f06bac23eff736a72a6ed6a/Data/ParlaMint-RO/ParlaMint-RO.xml#L72

        <bibl>
          <title type="main" xml:lang="en">Meeting minutes of the Romanian Parliament</title>
          <title type="main" xml:lang="ro">Stenograme ale şedinţelor din Parlamentul României</title>
          <idno type="URI">http://www.parlament.ro/</idno>
          <date from="2000-02-01" to="2020-11-24">2000-02-01 - 2020-11-24</date>
        </bibl>

https://github.com/romanian-parlamint/ParlaMint/blob/8439dd75ca3c31b89f06bac23eff736a72a6ed6a/Data/ParlaMint-RO/ParlaMint-RO.xml#L252

        <setting>
          <name type="city">Bucharest</name>
          <name type="place">Palace of the Parliament</name>
          <date from="2000-02-01" to="2020-11-24"/>
        </setting>

setting element

• setting element in root file

root file setting element should correspond to component ones (missing country)

https://github.com/romanian-parlamint/ParlaMint/blob/8439dd75ca3c31b89f06bac23eff736a72a6ed6a/Data/ParlaMint-RO/ParlaMint-RO.xml#L249-L253

        <setting>
          <name type="city">Bucharest</name>
          <name type="place">Palace of the Parliament</name>
          <date from="2000-02-01" to="2020-11-24"/>
        </setting>

vs:
https://github.com/romanian-parlamint/ParlaMint/blob/8439dd75ca3c31b89f06bac23eff736a72a6ed6a/Data/ParlaMint-RO/ParlaMint-RO_2000-04-14-id4927.xml#L97-L101

        <setting>
          <name type="city">Bucharest</name>
          <name type="country" key="RO">Romania</name>
          <date when="2000-04-14" ana="#parla.sitting">14.04.2000</date>
        </setting>

capitalize surname

• dont capitalize surname

https://github.com/romanian-parlamint/ParlaMint/blob/8439dd75ca3c31b89f06bac23eff736a72a6ed6a/Data/ParlaMint-RO/ParlaMint-RO.xml#L384

              <surname>GORGHIU</surname>

should be

              <surname>Gorghiu</surname>

sort component files

• sort component files

The component files should be ordered according to the contents' date.

taxonomies

• translations
• wrong language context - English content in xml:lang="ro"
• missing descriptions

[RePierre]

Changed the capitalization of surnames with commit 51787f7.

[RePierre]

Sorted component files in commit be08d9a.

[RePierre]

Changed note type to narrative with commit 9fe5f43.

[RePierre]

Converted notes into more specific elements within segments with commit cc386af.

[matyaskopp]

Spaces around notes

• spaces around notes inside text

Converted notes into more specific elements within segments with commit cc386af.

You have removed spaces around notes which can cause troubles in tokenization... It can happen that the note is inside the token (= unexpected behaviour of my annotation script).
https://github.com/romanian-parlamint/ParlaMint/blob/cc386afc90e1298cb4f4d79f44d5558949e4eeae/Data/ParlaMint-RO/ParlaMint-RO_2000-04-14-id4927.xml#L472

<seg xml:id="ParlaMint-RO_2000-04-14-id4927.u39.seg6">Cine este pentru?<vocal type="shouting"><desc>(Vociferără în partea dreaptă a sălii).</desc></vocal>Vă <!-- ... --> confuzie.</seg>

Should be:

<seg xml:id="ParlaMint-RO_2000-04-14-id4927.u39.seg6">Cine este pentru? <vocal type="shouting">
  <desc>(Vociferără în partea dreaptă a sălii).</desc>
</vocal> Vă <!-- ... --> confuzie.</seg>

[RePierre]

Added spaces around notes with commit 79b08b1.

[RePierre]

wrong language context - English content in xml:lang="ro"

Can you please provide an example?

I ran find -type f -name *.xml -exec grep --color=auto -i -nH --null -e lang\=\"ro\" \{\} +, went over all results, and wasn't able to find English content. Maybe I'm missing something?

[matyaskopp]

Can you please provide an example?

I ran find -type f -name *.xml -exec grep --color=auto -i -nH --null -e lang\=\"ro\" \{\} +, went over all results, and wasn't able to find English content. Maybe I'm missing something?

Oh, sorry - your <teiCorpus> is in English context:

<teiCorpus xmlns="http://www.tei-c.org/ns/1.0" xml:lang="en" xml:id="ParlaMint-RO">

This is the only corpus that has it. I implicitly expected that it has xml:lang="ro"

To search language context of <term> I now used

java -cp /usr/share/java/saxon.jar net.sf.saxon.Query -xi:off \!method=adaptive -qs:'//*[name()="term" and ./ancestor::*[@xml:lang][1]/@xml:lang="ro"]' -s:ParlaMint-RO/ParlaMint-RO.xml
<term xmlns="http://www.tei-c.org/ns/1.0">Legislatură</term>
<term xmlns="http://www.tei-c.org/ns/1.0">Unități geo-politice sau administrative</term>
<term xmlns="http://www.tei-c.org/ns/1.0">Legislatură națională</term>
<term xmlns="http://www.tei-c.org/ns/1.0">Organizație politică</term>
<term xmlns="http://www.tei-c.org/ns/1.0">Camere</term>
<term xmlns="http://www.tei-c.org/ns/1.0">Parlament bicameral</term>
<term xmlns="http://www.tei-c.org/ns/1.0">Senat</term>
<term xmlns="http://www.tei-c.org/ns/1.0">Camera deputaților</term>

The majority language in teiCorpus is usually English, so you have it correctly according to the documentation:

@xml:lang is also a global attribute and gives the language code of the text content of the element; for the corpus root this does not (just) mean the content of its TEI header, but primarily the textual content of its XIncluded components. The convention is that language of the text content of an element is determined by the value of the first @xml:lang attribute on its ancestor axis. In cases where the content is multilingual, the language code should be of the majority language. When the proportion of the languages is about equal, then the mul code for multiple languages can also be used.

but it is common to have the corpus language...

@TomazErjavec Can be english preserved in teiCorpus here?

[RePierre]

Normalized setting element in corpus root file and component files and set corpus span with commit d343920.

Should resolve:

setting element in root file
corpus timespan setting

[TomazErjavec]

@TomazErjavec Can be english preserved in teiCorpus here?

In practice I'd much rather not have an exception. So, teiCorpus and TEI should have @xml:lang="ro".
But maybe teiHeader with @xml:lang="en" is legit?

[RePierre]

Changed language of the teiCorpus element in commit 548e357.

[matyaskopp]

Duplicite person

• duplicite person

Every person should have one record in listPerson:
https://github.com/romanian-parlamint/ParlaMint/blob/548e3576054c9067aee43fb2275b879cac9ba806/Data/ParlaMint-RO/ParlaMint-RO.xml#L1306-L1324

          <person xml:id="Augustin-Lucian-Bolcas">
            <persName>
              <forename>Lucian</forename>
              <forename>Augustin</forename>
              <surname>Bolcaș</surname>
            </persName>
            <sex value="M"/>
            <affiliation ana="#RoParl.51" ref="#RoParl" role="member" from="2000-12-15" to="2004-11-30"/>
          </person>
          <person xml:id="Lucian-Augustin-Bolcas">
            <persName>
              <forename>Lucian</forename>
              <forename>Augustin</forename>
              <surname>Bolcaș</surname>
            </persName>
            <sex value="M"/>
            <affiliation ana="#RoParl.51" ref="#RoParl" role="member" from="2000-12-15" to="2004-11-30"/>
            <affiliation ana="#RoParl.52" ref="#RoParl" role="member" from="2004-12-19" to="2008-12-13"/>
          </person>

Necunoscut Necunoscut person's name

• Necunoscut Necunoscut

first occurence:
https://github.com/romanian-parlamint/ParlaMint/blob/548e3576054c9067aee43fb2275b879cac9ba806/Data/ParlaMint-RO/ParlaMint-RO.xml#L6030

          <person xml:id="Dan-Dumitrescu">
            <persName>
              <forename>Necunoscut</forename>
              <surname>Necunoscut</surname>
            </persName>
            <sex value="U"/>
            <affiliation ana="#RoParl.55" ref="#RoParl" role="member" from="2016-12-21" to="2020-12-20"/>
          </person>

[RePierre]

Missing speech content

As suggested by @TomazErjavec, added <gap> elements to the utterances without segments in commit 0082dd3.