Merge other PRs#8
Merged
claravanstaden merged 5 commits intoclaravanstaden:rename-eventfrom Mar 27, 2025
Merged
Conversation
Owner
claravanstaden
left a comment
claravanstaden
left a comment
There was a problem hiding this comment.
@yrong this diff is quite big. If I look at the 2 issues you linked in the PR description, there are other changes in here as well. I think we should stick to those two issues and revert unrelated changes. Otherwise we should rather keep these 2 PRs separate. Lets keep paritytech#8020 as focused and clear as possible.
| types::deneb, AncestryProof, BeaconHeader, ExecutionProof, VersionedExecutionPayloadHeader, | ||
| }; | ||
| use snowbridge_inbound_queue_primitives::{EventProof, InboundQueueFixture, Log, Proof}; | ||
| use snowbridge_inbound_queue_primitives::{EventFixture, EventProof, Log, Proof}; |
Owner
There was a problem hiding this comment.
Can you revert the renaming please?
Author
There was a problem hiding this comment.
I rename it because InboundQueueFixture will be reused when benchmarking the extrinsic submit_delivery_receipt for the outbound queue, so I prefer to make it more neutral.
claravanstaden
approved these changes
Mar 27, 2025
claravanstaden
merged commit 8003e31
into
claravanstaden:rename-event
99 of 190 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paritytech#8026
paritytech#8030