Automatically restart clangd language server after it is installed

[k0zmo]

No description provided.

[HighCommander4]

Thanks for the patch. The general approach looks reasonable to me. A few comments on the specifics:

[HighCommander4]

I believe a more conventional way to write this is:

this._pathUpdated = new Promise(resolve => {
  config.update('path', ...).then(resolve);
});

or alternatively:

this._pathUpdated = new Promise(async resolve => {
  await config.update('path', ...);
  resolve();
});

This avoids the extra variable _resolvePathUpdated, and also ensures that if the setter is called multiple times, awaiting _pathUpdated will correctly wait until the most recent promise is resolved.

[k0zmo]

I went with first option as config.update is not awaitable.

[HighCommander4]

We should null out _pathUpdated after having awaited it, to avoid any objects being unnecessarily kept alive

[HighCommander4]

I don't think we should ignore message entirely. Can we still show it in an info dialog, without waiting for the user to interact with it?

[k0zmo]

I think we can do this:

  async promptReload(message: string) {
    vscode.window.showInformationMessage(message)
    await this._pathUpdated;
    this._pathUpdated = null;
    vscode.commands.executeCommand('clangd.restart');
  }

Without await, this won't wait for user prompt and it would serve as a status message 'clangd ${version} is installed'. Is this what you had in mind?

[HighCommander4]

Yep, exactly

[HighCommander4]

LGTM