Skip to content

Fix lcm signature #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

Fix lcm signature #957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
028faf9
fix lcm signature
gus-massa Jul 13, 2025
68734db
add tests
mflatt Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mats/5_3.ms
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2592,6 +2592,14 @@
(eqv? (lcm 10.0 0.0 0.0 0.0) 0.0)
(eqv? (lcm 0.0 6.0 7.0 10.0) 0.0)
(eqv? (lcm 10.0 6.0 7.0 0.0) 0.0)
(eqv? (lcm 3E307 5E307) +inf.0)
(eqv? (lcm #e3E999 1.0) +inf.0)
(begin
;; make sure the optimizer doesn't assume an integer result
(define ($lcm-result x) (if (integer? (lcm x 1.0)) 'int 'non-int))
#t)
(eq? ($lcm-result 5) 'int)
(eq? ($lcm-result #e3E999) 'non-int)
)

(mat expt
Expand Down
2 changes: 1 addition & 1 deletion s/primdata.ss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@
(div0 [sig [(real real) -> (real)]] [flags arith-op mifoldable discard])
(mod0 [sig [(real real) -> (real)]] [flags arith-op mifoldable discard])
(gcd [sig [(integer ...) -> (integer)]] [flags arith-op mifoldable discard ieee r5rs])
(lcm [sig [(integer ...) -> (integer)]] [flags arith-op mifoldable discard ieee r5rs])
(lcm [sig [(integer ...) -> (real)]] [flags arith-op mifoldable discard ieee r5rs]) ; uinteger or +inf.0
(numerator [sig [(rational) -> (integer)]] [flags arith-op mifoldable discard ieee r5rs])
(denominator [sig [(rational) -> (integer)]] [flags arith-op mifoldable discard ieee r5rs])
(floor [sig [(real) -> (real)]] [flags arith-op mifoldable discard safeongoodargs ieee r5rs])
Expand Down