-
Notifications
You must be signed in to change notification settings - Fork 5
Description
🚀 Feature Proposal
Change the vulnscan.py job to use the pyTenable package for interfacing with the Nessus API.
Motivation
Leveraging a package to handle interfacing with the Nessus API would be beneficial for the following reasons:
- We would be able to eliminate the custom written
NessusControllerclass from both thevulnscan.pyjob andnessus_base.pyfile used to configure Nessus when an instance is spun up. - We could more easily implement testing with the
test_nessus.pyfile as it would no longer rely on thevulnscan.pyjob.
Pitch
Having the pyTenable package pre-installed wherever jobs are run would be a simple addition to cisagov/ansible-role-cyhy-runner as we have already added PyYAML to support retrieving Nessus access information from a file. Eliminating the NessusController class will also allow easier maintenance of any jobs that relied on it and ensure that anything that interacts with Nessus does so in a consistent manner. With this change we can also rope test_nessus.py into getting updated so we have a straightforward file to test that Nessus works without relying on running a job through it from the commander.