fix: prevent null max_tokens when using gpt-5 / gpt-5-mini #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

shota-kizawa wants to merge 1 commit into circlemind-ai:main from gzed-inc:fix/summarization_with_max_tokens

shota-kizawa commented Sep 23, 2025

Fix

Added proper handling to ensure max_tokens is always set to a valid value instead of null.
Verified that the request now succeeds with both gpt-5 and gpt-5-mini.

Related issue

Closes #103


          fix: prevent null max_tokens when using gpt-5 / gpt-5-mini

dda5125

Contributor

liukidar commented Oct 16, 2025

Hello,
this as it is would remove the possibility to pass max_tokens to any model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet