Add url previews with youtube embed player & room list avatar option#901
Closed
BatteredBunny wants to merge 21 commits intocinnyapp:devfrom
BatteredBunny:dev
Closed
Add url previews with youtube embed player & room list avatar option#901BatteredBunny wants to merge 21 commits intocinnyapp:devfrom BatteredBunny:dev
BatteredBunny wants to merge 21 commits intocinnyapp:devfrom
BatteredBunny:dev
Conversation
|
I think if the YouTube embeds should be implemented in a more generic way to make it easier to expand and add new embeds for more platforms later, as well as Matrix's URL Previews |
Author
I have thought about url previews, decided to leave them for a seperate pull request, YouTubeEmbed compontent is simple enough i don't think there will be a problem adapting it to something else like Reddit or Twitter |
…width in case they are in string form
Url previews
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist:
Preview: https://901--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️