Skip to content

Add url previews with youtube embed player & room list avatar option#901

Closed
BatteredBunny wants to merge 21 commits intocinnyapp:devfrom
BatteredBunny:dev
Closed

Add url previews with youtube embed player & room list avatar option#901
BatteredBunny wants to merge 21 commits intocinnyapp:devfrom
BatteredBunny:dev

Conversation

@BatteredBunny
Copy link
Copy Markdown

@BatteredBunny BatteredBunny commented Oct 8, 2022

Description

  • Adds url preview option

image

image

  • Special case for youtube

image

image

  • Adds room list avatar option

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://901--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@Airyzz
Copy link
Copy Markdown

Airyzz commented Oct 9, 2022

I think if the YouTube embeds should be implemented in a more generic way to make it easier to expand and add new embeds for more platforms later, as well as Matrix's URL Previews

@BatteredBunny
Copy link
Copy Markdown
Author

I think if the YouTube embeds should be implemented in a more generic way to make it easier to expand and add new embeds for more platforms later, as well as Matrix's URL Previews

I have thought about url previews, decided to leave them for a seperate pull request, YouTubeEmbed compontent is simple enough i don't think there will be a problem adapting it to something else like Reddit or Twitter

@BatteredBunny BatteredBunny changed the title Adds room list avatar option & youtube embed player option Add url previews with youtube embed player & room list avatar option Nov 17, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants