feat: Add video call support by hazre · Pull Request #2599 · cinnyapp/cinny

hazre · 2026-02-11T16:02:58Z

Description

Fixes #528

Revives and continues #2335 (Element Call support), as the original PR has stalled.

Merged dev into this branch, resolved conflicts, and incorporated patches from @YoJames2019 to bring everything up to date and reviewable.

Marked as draft for now since some UX/polish improvements are still needed.

Credits to @GigiaJ for the original implementation and @YoJames2019 for follow up patches.

Here's laundry list of things I feel like should be addressed before merging: (Feedback welcome!)

Need to fix (help would be appreciated):

Nice to haves:

Show a badge on space if in a voice room.
User voice status in the room sidebar. (Blocked by official Element-call)
User Muted Status in room sidebar. (Blocked by official Element-call)
widget Folds/Cinny theming. (Blocked by official Element-call)
Request Camera permissions only on enabling camera.
Show duration of the call in the call status navigation.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings

Preview: https://2599--pr-cinny.netlify.app/

Any feedback/Questions, please post in the dedicated thread: #2599 (comment)

… as an in place option on send)

…as intended)

…m widget info at start instead)

…against

…child object of)

…a state and hangup

…pe instead of using any) in widgetUrl

… based on join + hang up actions

RoflMyPancakes · 2026-02-19T16:13:50Z

I've been following this and able to use this just fine when built for web over the last few days, but when I build cinny-desktop with cinny on this branch, joining voice rooms hangs indefinitely from cinny-desktop (shows "Joining").

I just thought saying this sooner might get more eyes on the cinny-desktop angle.

Works fine with chrome, firefox.
But with cinny-desktop with Tauri it's behaving differently.

/public/element-call/index.html requests end up returning cinny's index instead.

Query params break the file lookup in cinny-desktop. I was able to test:

/public/element-call/index.html => Resolves to Element Call
/public/element-call/index.html?embed=true => Resolves to Cinny (not found, fallback to index)

I'm assuming (based on some research of tauri's localhost plugin) that Tauri's localhost resolver doesn't strip query parameters before looking up the file. It tries to find index.html?embed=true literally (including query params), fails, and falls back to the root index.html.

I've been able to fix it a couple different ways in my testing but that's the core problem I hit. I don't know what the most elegant solution is if I'm right about this being a problem.

I was able to fix it in just cinny by changing to url.hash from url.search, which caused other problems but I could at least join voice rooms. But changing cinny-desktop to not use the tauri localhost plugin could be another path.

Maybe someone more experienced with cinny-desktop should run this branch through a test.

Edit: The solution for me was to patch Tauri's localhost plugin (though it seems 2.x of tauri includes a localhost plugin with this fix). This made the fix entirely on the cinny-desktop side and I can use this branch unchanged.

// Original plugin:
asset_resolver.get(req.url().into())

// Patched plugin:
let path = req.url().split('?').next().unwrap_or(req.url()).into();
asset_resolver.get(path)

With that change, cinny-desktop works with this branch. Without it, joining voice rooms fails (the element-call iframe fails)

group duplicate conditions into one

- rename CreateRoomVoice to CreateRoomType and modal voice state to type - rename CreateRoomKind to CreateRoomAccess and KindSelector to AccessSelector - propagate access/defaultAccess through create room and create space forms - set voice room power levels via createRoom power_level_content_override

- bump folds from 2.5.0 to 2.6.0 - replace separate room/space join-rule icon hooks with useJoinRuleIcons(roomType) - route join-rule icons through getRoomIconSrc for consistent room type handling - simplify getRoomIconSrc by removing the locked override path - use VolumeHighGlobe for public call rooms and VolumeHighLock for private call rooms

…le-api

…anup

- show filled User icon when the drawer is open

jeanbono · 2026-02-20T11:30:12Z

The commit 30303fe break the calls for me.
I'm getting disconnected almost immediatly after joining.
Everything is working fine with the previous commit (881da5c)

hazre · 2026-02-20T12:55:24Z

The commit 30303fe break the calls for me. I'm getting disconnected almost immediatly after joining. Everything is working fine with the previous commit (881da5c)

Yeah it looks like the element call version we are using, uses 1.13.0 version of widget api package. For now I will downgrade it.

This reverts commit a4c34ef.

hazre · 2026-02-20T14:20:02Z

@jeanbono I've pushed some changes to address that, see if it works now

jeanbono · 2026-02-20T14:23:44Z

@jeanbono I've pushed some changes to address that, see if it works now

Looks good now 👍

- fixes not working on firefox

vrisalab · 2026-02-20T21:42:27Z

I've been testing this, and I've found a bug: When you join a room, and then close the tab, your user never leaves the call, not even after a server restart. If the user was sharing their screen, the screen remains perpetually shared. I'm not sure if the behavior is the same on Element.

GigiaJ · 2026-02-20T21:53:11Z

shared. I'm not sure if the behavior is the same on Element.

You can do this on Element too. Quirk of Element Call I imagine. User has to timeout from the LiveKit SFU. That is why a server restart doesn't DC them even unless you restart that too I believe.

Sollace · 2026-02-20T22:55:54Z

I've been testing this, and I've found a bug: When you join a room, and then close the tab, your user never leaves the call, not even after a server restart. If the user was sharing their screen, the screen remains perpetually shared. I'm not sure if the behavior is the same on Element.

Ah yeah, I've seen this as well in fact when my browser has crashed whilst in a call.

@GigiaJ Is it possible to add something in to trigger the user leaving the call properly when the tab is closed?

i.e. Using the beforeunload window event or similar?

chxreyes · 2026-02-21T16:54:26Z

Is the preview up to date with the current PR diff? Calls do not seem to work for me using the preview.

xetem · 2026-02-21T21:26:57Z

Is the preview up to date with the current PR diff? Calls do not seem to work for me using the preview.

Yeah I'm getting stuck trying to join a call in a call room without it ever resolving, can join the room successfully on Element.

kfiven · 2026-02-22T07:08:44Z

Merging this in voice-calls PR for further testing. #2680

GigiaJ added 30 commits April 21, 2025 01:39

Add call status to bottom of home nav

79b4303

Move out bottom nav into own file

40a25aa

add creation handling for calls by setting creation content type

0fb5ffc

Add room type option

39e7de3

Remove text chat for now

5ae8064

Add a check for space to hide option in space creation

02cb7ea

Revert casing to fix bottom nav status buttons (should swap back when…

7beb841

… as an in place option on send)

Place holder buttons

5677042

add call status bar call room link

6d4b37f

re-enable header buttons globally for now

1573353

The reuse is substantial enough to justify including the license

2f980a7

The code reuse is substantial enough to justify including the license

c7ea3f7

Fix DM header since it *can* be a call room

a4af96b

Remove chat open icon from DMs

f7fb4bc

Fix syntaxical mistake causing chat open state to never update

c8790a5

Enable chat toggle for call rooms (still needs cleaner UI, but works …

6691467

…as intended)

Disable DM calling button for now (not implemented properly yet)

39d4eed

Set mic default state to be generally accurate (need to set state fro…

d6ffac7

…m widget info at start instead)

Prevents undefined object from being checked for values and filtered …

b5ca54d

…against

update references to transport to clientwidgetapi (as transport is a …

1e8a69f

…child object of)

Update transport refs to allow us to properly bind listeners for medi…

e766640

…a state and hangup

Add some parameters to be settable (need to create an param object ty…

8700fe8

…pe instead of using any) in widgetUrl

Always embed to give a proper call room lobby experience

4779b09

Add tooltips and properly implement the navlink

b4d9828

add join, screen_state, and hang up handling as well as logging state…

ec74142

… based on join + hang up actions

Activate when active call state is false

a555190

Add call room icon (needs variations based on join rules)

7ce3b40

add call as a param to pass

8c6a626

add chat button handling for call rooms and impl call room icon

96be8e1

add isCallActive to memo

8038c2a

hazre and others added 11 commits February 19, 2026 20:15

Merge pull request #7 from YoJames2019/fix/room-header-cleanup-1

c97fba7

group duplicate conditions into one

chore(deps): bump matrix-widget-api to 1.17 and remove react-sdk-modu…

30303fe

…le-api

fix: adapt SmallWidget to matrix-widget-api 1.17.0 API

a4c34ef

fix: render call room chat only when chat panel is open

0f047e5

fix(permissions): show call settings permissions only for call rooms

ff3def0

refactor: remove redundant room-nav props/guards and minor naming cle…

7f1a465

…anup

fix: use PhoneDown icon for hang up action

5b7e96f

chore(hooks): remove unused useStateEvents hook

578cb86

fix(room): enable members drawer toggle in desktop call rooms

21e596d

- show filled User icon when the drawer is open

hazre requested review from ajbura and kfiven February 19, 2026 23:20

hazre marked this pull request as ready for review February 19, 2026 23:20

hazre added 2 commits February 20, 2026 14:34

Revert "fix: adapt SmallWidget to matrix-widget-api 1.17.0 API"

8aedad0

This reverts commit a4c34ef.

fix: semi-revert matrix-widget-api 1.17 bump and migrate to 1.13 API

f463f3e

fix(call): wait for Element Call contentLoaded before widget handshake

459b52e

- fixes not working on firefox

kfiven merged commit 65c3c7e into cinnyapp:voice-calls Feb 22, 2026
1 check passed

github-actions bot locked and limited conversation to collaborators Feb 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add video call support#2599

feat: Add video call support#2599
kfiven merged 306 commits intocinnyapp:voice-callsfrom
hazre:feat/element-call

hazre commented Feb 11, 2026 •

edited

Loading

Uh oh!

RoflMyPancakes commented Feb 19, 2026 •

edited

Loading

Uh oh!

jeanbono commented Feb 20, 2026

Uh oh!

hazre commented Feb 20, 2026

Uh oh!

hazre commented Feb 20, 2026

Uh oh!

jeanbono commented Feb 20, 2026

Uh oh!

vrisalab commented Feb 20, 2026

Uh oh!

GigiaJ commented Feb 20, 2026

Uh oh!

Sollace commented Feb 20, 2026 •

edited

Loading

Uh oh!

chxreyes commented Feb 21, 2026

Uh oh!

xetem commented Feb 21, 2026

Uh oh!

Uh oh!

kfiven commented Feb 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

hazre commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Here's laundry list of things I feel like should be addressed before merging: (Feedback welcome!)

Need to fix (help would be appreciated):

Nice to haves:

Type of change

Checklist:

Uh oh!

RoflMyPancakes commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeanbono commented Feb 20, 2026

Uh oh!

hazre commented Feb 20, 2026

Uh oh!

hazre commented Feb 20, 2026

Uh oh!

jeanbono commented Feb 20, 2026

Uh oh!

vrisalab commented Feb 20, 2026

Uh oh!

GigiaJ commented Feb 20, 2026

Uh oh!

Sollace commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chxreyes commented Feb 21, 2026

Uh oh!

xetem commented Feb 21, 2026

Uh oh!

Uh oh!

kfiven commented Feb 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

hazre commented Feb 11, 2026 •

edited

Loading

RoflMyPancakes commented Feb 19, 2026 •

edited

Loading

Sollace commented Feb 20, 2026 •

edited

Loading