Show image viewer when clicking url preview thumbnail#2309
Merged
ajbura merged 4 commits intocinnyapp:devfrom Mar 14, 2026
Merged
Show image viewer when clicking url preview thumbnail#2309ajbura merged 4 commits intocinnyapp:devfrom
ajbura merged 4 commits intocinnyapp:devfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA. |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Apr 19, 2025
Contributor
Author
|
Alright I'm pretty happy with it now. Feel free to request changes as I'm not sure if this is the correct location for the new component. |
|
Preview: https://2309--pr-cinny.netlify.app |
|
Cherry-picked this over the v4.10.2 tag, seems to work well in my short testing of it. Anything blocking this from being merged? |
9 tasks
966688d to
4bc4e10
Compare
4bc4e10 to
4d68d91
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Show an image viewer when clicking the thumbnail in the url preview, similar to Element. Uses the same code as image content, maybe some deduplication necessary.
Type of change
Checklist: