Being re-added to a DM results in the room being displayed in "Home" space rather than "People"

[rail01]

Describe the bug

When one participant of the Direct Messages room leaves and is later re-added to the room, said room on their end is displayed in the "Home" space under "Rooms" category rather than in "People"

Reproduction

1. Start a DM (it will be displayed in "People")
2. Leave the DM
3. Have the remaining account re-add you to the DM
4. DM room is now displayed among regular rooms

Expected behavior

DM rooms are still displayed in "People" space after being re-added after leaving

Platform and versions

Cinny 3.2.0 on Firefox 124.0.1

Additional context

No response

[williamkray]

this might have been fixed with #1848 considering it was a similar problem.

[NotNite]

I experience the same issue on v4.1.0, but when starting a new DM from my phone (Element X on Android) and opening Cinny afterwards.

[rail01]

This can be manually fixed on a per-room basis by sending /converttodm but it should be sorted out automatically without user having to use commands

[williamkray]

/converttodm seems to not be working anymore, and all new DMs created recently are showing up in Home with no way to "fix" manually.

logic for determining what is a "DM" should shift toward the "heroes" method of identifying DMs, and optionally follow guidance of MSC4171 to ignore bots or other service accounts for proper bridge behavior.

all of this is in lieu of the lack of definition for canonical DMs in spec.