*: use go tool instead of go run in go:generate statements
#1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.24 introduces the new `tool` statement in go.mod. Add it with `go get -tool golang.org/x/tools/cmd/stringer@latest` to make code gen more consistent and reproducible across time and Go versions. Signed-off-by: Timo Beckers <[email protected]>
For internal tools, `go tool` provides nice shorthands instead of the typical `go run ...` with the full module path. Use this convention for bpf2go and gentypes. Signed-off-by: Timo Beckers <[email protected]>
dylandreimerink
previously approved these changes
Oct 13, 2025
Member
|
Changes look good. But, I guess we need to figure out a way to let staticcheck ignore generated files 🙄 |
lmb
previously approved these changes
Oct 13, 2025
Signed-off-by: Timo Beckers <[email protected]>
dylandreimerink
approved these changes
Oct 13, 2025
Collaborator
Author
|
@lmb Could use some input here on why the Windows tests could be failing. x/sys got an upgrade in this PR, could be the culprit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to
stringerbroke main, so it's time to usego toolfor all go:generate statements. Use it for internal tools too, and suggest it as a best practice in documentation and help text.