ringbuf: Use uintptr for positions for 32-bit compatibility #1843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM, could you squash this into one commit and add a commit message explaining the change? I'm assuming that you tested this locally and that it works. |
Signed-off-by: Joshua McBeth <[email protected]>
Contributor
Author
|
squashed, and passes all tests on 32-bit and 64-bit -- see original issue for 32-bit test logs |
florianl
approved these changes
Aug 6, 2025
Contributor
Author
|
additionally validated against a live kernel for no regression in 64-bit case here: https://github.com/joshuamcbeth/ebpf-ringbuf-test |
Collaborator
|
@florianl out of curiosity, are you able to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1835