Skip to content

map: fix problematic error returns #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmb merged 1 commit into from
Mar 10, 2025
Merged

map: fix problematic error returns #1715

lmb merged 1 commit into from
Mar 10, 2025

Conversation

@cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Mar 8, 2025

We have already judged err before. Therefore, err here must be nil.

Here sysErr should be returned instead of err.

@cuishuang cuishuang requested a review from a team as a code owner March 8, 2025 15:38
florianl
florianl approved these changes Mar 8, 2025
View reviewed changes
Copy link
Contributor

@florianl florianl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@lmb lmb merged commit 531420c into cilium:main Mar 10, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmb lmb lmb approved these changes

@florianl florianl florianl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cuishuang @lmb @florianl