info: expose additional bpf_prog_info fields in ProgramInfo
#1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @tyrone-wu, thanks for your contribution! Please take a look at the comment I wrote in #1515 which explains how to extend the Info API. Please also add tests for the API you're introducing. |
tyrone-wu
force-pushed
the
info/expose-info-fields
branch
from
f8c72b7 to
56324bb
Compare
ti-mo
requested changes
Sep 5, 2024
Collaborator
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
@tyrone-wu Ping, are you still interested in merging this? This is good to go IMO with one fixup. I'll pull it out of draft so it's more visible.
florianl
reviewed
Sep 5, 2024
Contributor
Author
|
Sorry for the delay, I've been caught in some other things. I can definitely get this done by the end of today. 😺 🙏 |
tyrone-wu
force-pushed
the
info/expose-info-fields
branch
3 times, most recently
from
2bef624 to
9fcab04
Compare
dylandreimerink
approved these changes
Sep 9, 2024
Member
dylandreimerink
left a comment
dylandreimerink
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
florianl
approved these changes
Sep 9, 2024
Contributor
florianl
left a comment
florianl
left a comment
There was a problem hiding this comment.
thanks for the update 👍
ti-mo
requested changes
Sep 11, 2024
Collaborator
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
I thought I'd already left a code review earlier, sorry for the delay.
tyrone-wu
force-pushed
the
info/expose-info-fields
branch
from
9fcab04 to
4ad10eb
Compare
Exposes additional metadata fields from `bpf_prog_info` to `ProgramInfo`: - jited_prog_len - xlated_prog_len - load_time - verified_insns Signed-off-by: tyrone-wu <[email protected]>
ti-mo
force-pushed
the
info/expose-info-fields
branch
from
4ad10eb to
c63f95d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋
I'm implementing a Telegraf plugin that extracts metadata information from the
bpf_prog_infoobject. There's some additional fields that I'd like to include in the metric, that aren't exposed inProgramInfo.The additional fields that are exposes are:
jited_prog_lenxlated_prog_lenload_timeverified_insns