Add Remaining and Size to perf/ring Record #1167
Conversation
brycekahle
force-pushed
the
bryce.kahle/perf-usage
branch
from
52c47f9 to
3b522ca
Compare
lmb
left a comment
lmb
left a comment
There was a problem hiding this comment.
Looks good, can you add test coverage please?
perf/reader.go
Outdated
| Remaining int | ||
|
|
||
| // The total size of the per-CPU perf buffer in bytes. | ||
| Size int |
There was a problem hiding this comment.
Size is fixed for the reader, why not expose this as Reader.Size() int instead? You can move the call to perfBufferSize from newPerfEventRing to NewReaderWithOptions. Same idea applies to ringbuf.Reader.
There was a problem hiding this comment.
The size we are interested in, is the data portion, without the metadata page. Moving the call to perfBufferSize would've required changes to a bunch of other places that expect newPerfEventRing to handle the size manipulation. I did something different, let me know what you think.
brycekahle
force-pushed
the
bryce.kahle/perf-usage
branch
from
433565f to
515ea9b
Compare
Added. For the backward/overwriteable buffer it isn't possible to get a precise remaining count once it has been overwritten. |
lmb
left a comment
lmb
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding the tests! Final question: seems like the semantics for overwritable aren't clear. Should we just set remaining to -1 for now in that case and document that this means the data remaining can't be determined?
We could. It does work correctly until any kind of overwrite happens, and then it becomes inaccurate by reporting more data remaining than their actually is (because of the partial leftover records). |
lmb
left a comment
lmb
left a comment
There was a problem hiding this comment.
Pushed a doc fix. Please squash then we are good to go.
Signed-off-by: Bryce Kahle <[email protected]> Signed-off-by: Lorenz Bauer <[email protected]>
brycekahle
force-pushed
the
bryce.kahle/perf-usage
branch
from
220e1e7 to
5a0992d
Compare
|
squashed |
|
@lmb ready to go. |
2 participants
This allows tracking utilization of the underlying buffers. Processing the values to make sense in a user's monitoring system is left to the user.
Using the post-read remaining bytes allows the value to reach zero, whereas a pre-read value would never reach zero.