New formatters %.3f, %.6f, %.9f #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifthrasiir
added a commit
that referenced
this pull request
Sep 5, 2015
New formatters %.3f, %.6f, %.9f
Contributor
|
@tomgco I was thinking hard about the generic width/precision specification (which I didn't seriously try to adapt, but glibc and some others have that and I assume we eventually need to do so), but #46 will force pushing a new version to crates.to anyway and I don't see any further reason to delay accepting this except that we will want to do this more generally. Thank you and sorry for delay! |
lifthrasiir
added a commit
that referenced
this pull request
Sep 6, 2015
- Added `%.3f`, `%.6f` and `%.9f` specifier for formatting fractional seconds up to 3, 6 or 9 decimal digits. This is a natural extension to the existing `%f`. Note that this is (not yet) generic, no other value of precision is supported. (#45) - Forbade unsized types from implementing `Datelike` and `Timelike`. This does not make a big harm as any type implementing them should be already sized to be practical, but this change still can break highly generic codes. (#46) - Fixed a broken link in the `README.md`. (#41) - Tons of supporting examples for the documentation have been added. More to come.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to print out a fixed precision to ensure that the output would always match no matter what the input was, for example
70msneeds to output.070and0msneeds to print.000.I am really new to rust and I hope that this is OK.
I tried to create a macro that would construct Nanosecond{3,6,9} however to do that I needed to use
std::concat_idents!which was unstable so you are left with a more verbose matching. If you have any improvements let me know on this PR let me know.Thanks.