Skip to content

Support turbosnap for pull_request workflow trigger #731

@quantizor

Description

@quantizor

The pull_request event object does contain the sha for the base commit that triggered the workflow run. Can't you just use github.event.pull_request.base.sha to do your historical calculations and thus be able to support that trigger without further upset?

As an aside, I noticed the action directly references the github event json and has a switch statement to fork the handling based on workflow trigger. It'd be nice if the action leveraged the typical github environment variables instead so it's easier to override from the downstream consumer's perspective.

Metadata

Metadata

Assignees

No one assigned

    Labels

    CLIneeds triageTracking: Issue needs confirmation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions