[BUG]: Make FlushCollectionCompactionAndAttachedFunction transactional

[tanujnay112]

Description of changes

FlushCollectionCompaction and FlushAttachedFunction did not execute in the same transaction before and this diff changes that.

• Improvements & Bug fixes
  • ...
• New functionality
  • ...

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the _docs section?_

[tanujnay112]

• [BUG]: Make FlushCollectionCompactionAndAttachedFunction transactional #5779 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[propel-code-bot]

Tie FlushCollectionCompaction + attached-function updates into a single DB transaction

Makes collection compaction and its attached-function bookkeeping atomic. The core change threads an optional *gorm.DB down to FlushCollectionCompactionForVersionedCollection, so callers that already run inside a Transaction() block can reuse the same connection. Retry logic, CAS safeguards and context updates were adjusted accordingly. A small proto-build fix in task.go removes the unused LowestLiveNonce field.

Key Changes

• Added gorm.io/gorm import and optional *gorm.DB tx parameter to FlushCollectionCompactionForVersionedCollection in go/pkg/sysdb/coordinator/table_catalog.go
• Updated FlushCollectionCompaction, FlushCollectionCompactionAndAttachedFunction, and surrounding helpers to pass the current transaction and skip nested transactions when tx != nil
• Introduced maxAttemptsForThisCall to disable retry loops when running inside an outer transaction
• Refactored segment/tenant updates to accept a context that may contain the active transaction via dbcore.CtxWithTransaction
• Removed always-nil LowestLiveNonce assignment from attached-function proto construction in go/pkg/sysdb/coordinator/task.go

Affected Areas

• table_catalog.go (compaction / version-file logic)
• task.go (attached-function proto serialisation)

This summary was automatically generated by @propel-code-bot