Skip to content

[BUG] Fork log should error on incomplete manifest #5771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sicheng-Pan merged 2 commits into from
Oct 30, 2025
Merged

[BUG] Fork log should error on incomplete manifest #5771

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
742cce5
[BUG] Fork log should error on incomplete manifest
Sicheng-Pan Oct 30, 2025
9ede12d
Use the same manifest to read range
Sicheng-Pan Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions rust/log-service/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,6 +1452,17 @@ impl LogServer {
Arc::clone(&storage),
target_prefix,
);
let first_copied_offset = log_reader.oldest_timestamp().await.map_err(|err| {
Status::new(
err.code().into(),
format!("Failed to read first offset in copied manifest: {}", err),
)
})?;
if offset < first_copied_offset {
return Err(Status::internal(format!(
"Compaction cursor [{offset:?}] is behind start of manifest [{first_copied_offset:?}]",
)));
}
// This is the next record to insert, so we'll have to adjust downwards.
let max_offset = log_reader.next_write_timestamp().await.map_err(|err| {
Status::new(
Expand Down
Loading