(#16) Updated reliance on MD5 to use sha256 if FIPS is enabled #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Sep 1, 2025
ripienaar
requested changes
Sep 1, 2025
There was a problem hiding this comment.
Thanks @gerrity95
Few things here:
- Make go.mod use the same as
go-choria:go 1.24.0 - Update the GitHub tests to do
go: ["1.24", "1.25"] - We need to figure out how to test this but that might be a fair few changes to testing actions so leave for now I'll revisit and see about adding a test
…ions and fixed missing variable in server.go
ripienaar
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to see if the binary is FIPS compliant and if so, will use sha256 and if it isn't, it'll use MD5