Add FILE_SET and RUNTIME_DEPENDENCIES support#354
Open
solarispika wants to merge 4 commits intocheshirekow:masterfrom
Open
Add FILE_SET and RUNTIME_DEPENDENCIES support#354solarispika wants to merge 4 commits intocheshirekow:masterfrom
solarispika wants to merge 4 commits intocheshirekow:masterfrom
Conversation
parse_install_targets_sub was defined but never called. The code incorrectly used parse_install_targets recursively for designated kwargs (ARCHIVE, LIBRARY, RUNTIME, etc.), which was overly permissive since it allowed top-level keywords inside nested groups.
Add support for the FILE_SET keyword used in target_sources() and install(TARGETS) commands. FILE_SET requires a set name argument followed by optional TYPE, BASE_DIRS, FILES, DESTINATION, etc. kwargs. - Add FileSetNode class for parsing FILE_SET syntax - Update target_sources() to handle FILE_SET keyword - Update install(TARGETS) to handle FILE_SET with its specific subparser - Add tests for adding new keywords
Add support for runtime dependency handling in install(): - RUNTIME_DEPENDENCY_SET as standalone install form - RUNTIME_DEPENDENCIES and RUNTIME_DEPENDENCY_SET in install(TARGETS) Both support filtering options (PRE/POST_INCLUDE/EXCLUDE_REGEXES, POST_INCLUDE/EXCLUDE_FILES, DIRECTORIES).
solarispika
force-pushed
the
feature/file-set-and-runtime-deps
branch
from
fafbde8 to
4f20617
Compare
|
Might I ask you to also support However, thank you very much for your work! I hope that this project ist not dead. |
CXX_MODULES_BMI is an artifact kind for installing Binary Module Interface files from C++20 modules. It supports the same options as other artifact kinds: DESTINATION, PERMISSIONS, CONFIGURATIONS, COMPONENT, OPTIONAL, EXCLUDE_FROM_ALL.
Author
|
@Spixmaster Sure, I've pushed new commit for CXX_MODULES_BMI support. |
solarispika
force-pushed
the
feature/file-set-and-runtime-deps
branch
2 times, most recently
from
e2e0f69 to
38945f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_install_targetsto useparse_install_targets_sub(was dead code)target_sources()andinstall(TARGETS)(CMake 3.23+)install(RUNTIME_DEPENDENCY_SET)as standalone formRUNTIME_DEPENDENCIESandRUNTIME_DEPENDENCY_SETininstall(TARGETS)(CMake 3.21+)Test plan