Skip to content

Fix types #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2021
Merged

Fix types #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7dcef61
Fix types
karlhorky Feb 25, 2021
19a4eb0
Fix types
karlhorky Feb 25, 2021
1c2c0c0
Fix test
karlhorky Feb 25, 2021
8b3866d
Add cast
karlhorky Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ declare namespace cheerio {

eq(index: number): Cheerio;

get(): any[];
get(index: number): any;
get(): Element[];
get(index: number): Element | undefined;

index(): number;
index(selector: string): number;
Expand Down
5 changes: 3 additions & 2 deletions types/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { expectType } from 'tsd';
import { Element } from 'domhandler';
import cheerio from '..';

/*
Expand All @@ -19,7 +20,7 @@ cheerio(html);
cheerio('ul', html);
cheerio('li', 'ul', html);

const $fromElement = cheerio.load($('ul').get(0));
const $fromElement = cheerio.load($('ul').get(0) as Element);

if ($fromElement('ul > li').length !== 3) {
throw new Error(
Expand Down Expand Up @@ -248,7 +249,7 @@ $el.eq(0).text();
$el.eq(-1).text();

// .get( [i] )
$el.get(0).tagName;
$el.get(0)?.tagName;
$el.get().length;

// .index()
Expand Down