Circular dependencies giving rollup fits

[GreenGremlin]

Circular dependencies are valid in cjs, but create all kinds of issues when converted to es6. I'm not familiar with the Cheerio code, but wanted to open this issue to see how feasible it may be to factor out Cheerio's circular dependencies.

Rollup output (slightly re-formatted)

Circular dependency: node_modules/cheerio/lib/cheerio.js ->
        node_modules/cheerio/lib/api/attributes.js ->
        node_modules/cheerio/lib/static.js ->
        node_modules/cheerio/lib/cheerio.js
Circular dependency: node_modules/cheerio/lib/cheerio.js ->
        node_modules/cheerio/lib/api/attributes.js ->
        node_modules/cheerio/lib/static.js ->
        commonjs-proxy-/Users/jonathan/my-package/node_modules/cheerio/lib/cheerio.js ->
        node_modules/cheerio/lib/cheerio.js

[fb55]

Happy to accept PRs :)

[Sureiya]

This doesn't exist in 1.0.0 branch but does exist in 1.0.0rc.3, there is another circular dependency happening with html2parser versions less than 4.0.0 as well.

[tobiasmuehl]

Any updates on this?

[fb55]

Just published a new release, which should resolve this if it is resolved on the master branch.

[tvanc]

I'm still getting this exact issue on 1.0.0-rc5

[5saviahv]

It is not fixed in 1.0.0-rc5, fix is currently available only in github

[fb55]

Fixed in RC6.