don't send entity when get/delete have no body#116
Merged
kares merged 1 commit intocheald:masterfrom Jun 13, 2025
Merged
Conversation
Currently a non-body get/delete will sent a "Content-Length: 0" header given the httpclient is passed a request object with Entity. While RFC 7230 does allow for non-body requests to have "Content-Length: 0" it is marked as a SHOULD NOT and can cause problems in stricter environments. This commit changes that, where a no body request will use non-entity objects.
jsvd
force-pushed
the
dont_use_entity_without_body
branch
from
c2b64a8 to
07dace1
Compare
Contributor
Author
Contributor
Author
|
Thanks @kares! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a non-body get/delete will sent a "Content-Length: 0" header given the httpclient is passed a request object with Entity.
While RFC 7230 does allow for non-body requests to have "Content-Length: 0" it is marked as a SHOULD NOT and can cause problems in stricter environments.
This commit changes that, where a no body request will use non-entity objects.
fixes logstash-plugins/logstash-input-http_poller#150